Skip to content

8335: Duplicate values in tooltip for RSS and RSS (Peak) in memory tab #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8335: Duplicate values in tooltip for RSS and RSS (Peak) in memory tab #685

wants to merge 1 commit into from
+5 −2

Conversation

@aymane-harmaz
Copy link
Member

@aymane-harmaz aymane-harmaz commented Nov 12, 2025 •
edited by openjdk bot
Loading

This PR makes sure, we do not add attributes twice to the same renderer on the memory page

The issue :

  • The supplier used for merging events was having a side effect (calls to methods adding attributes to the same renderer)
  • The supplier was consumed twice leading to the side effect being executed twice and that is mainly what causes the tooltip to contain duplicated attributes on the memory page

The following screenshots respectively show the tooltips before and after the change

tooltip-before tooltip-fixed

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8335: Duplicate values in tooltip for RSS and RSS (Peak) in memory tab (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/685/head:pull/685
$ git checkout pull/685

Update a local copy of the PR:
$ git checkout pull/685
$ git pull https://git.openjdk.org/jmc.git pull/685/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 685

View PR using the GUI difftool:
$ git pr show -t 685

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/685.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025 •
edited
Loading

@aymane-harmaz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335: Duplicate values in tooltip for RSS and RSS (Peak) in memory tab

Reviewed-by: hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Gunde) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr label Nov 12, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2025

Webrevs

@aymane-harmaz
Copy link
Member Author

aymane-harmaz commented Nov 24, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@aymane-harmaz
Your change (at version 97a7f2c) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Gunde Gunde Gunde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready rfr sponsor

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aymane-harmaz @Gunde